[
https://issues.apache.org/jira/browse/TEXT-151?focusedWorklogId=206793&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-206793
]
ASF GitHub Bot logged work on TEXT-151:
---------------------------------------
Author: ASF GitHub Bot
Created on: 02/Mar/19 21:14
Start Date: 02/Mar/19 21:14
Worklog Time Spent: 10m
Work Description: aherbert commented on pull request #105: TEXT-151: Use
StringUtils.equals to test for CharSequence equality.
URL: https://github.com/apache/commons-text/pull/105
Comparing CharSequence using Object.equals will fail when the CharSequence
implementation does not support this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 206793)
Time Spent: 10m
Remaining Estimate: 0h
> JaroWinklerSimilarity uses Object.equals to test for equality
> -------------------------------------------------------------
>
> Key: TEXT-151
> URL: https://issues.apache.org/jira/browse/TEXT-151
> Project: Commons Text
> Issue Type: Bug
> Affects Versions: 1.7
> Reporter: Alex D Herbert
> Priority: Trivial
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Using Object.equals to test for equality of a {{CharSequence}} is wrong:
> {code:java}
> CharSequence cs1, cs2;
> cs1.equals(cs2);
> {code}
> The Unit test passes because the test uses the same String on both sides.
> When I changed the unit test to wrap the string with a {{CharSequence}}
> interface it fails.
> It should be replaced with:
> {code:java}
> CharSequence cs1, cs2;
> StringUtils.equals(cs1, cs2);
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
