[
https://issues.apache.org/jira/browse/TEXT-153?focusedWorklogId=207432&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207432
]
ASF GitHub Bot logged work on TEXT-153:
---------------------------------------
Author: ASF GitHub Bot
Created on: 04/Mar/19 21:10
Start Date: 04/Mar/19 21:10
Worklog Time Spent: 10m
Work Description: coveralls commented on issue #108: TEXT-153: Make
prefixSet a BitSet.
URL: https://github.com/apache/commons-text/pull/108#issuecomment-469422912
[](https://coveralls.io/builds/21979585)
Coverage remained the same at 97.885% when pulling
**1e38ed585e9160b2765e9c94401c7d5fdf17f90c on
amirhadadi:TEXT-153-lookup-translator** into
**79227c5a047a45e45afd14c1acc408811de29eda on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 207432)
Time Spent: 20m (was: 10m)
> LookupTranslator performance optimization
> -----------------------------------------
>
> Key: TEXT-153
> URL: https://issues.apache.org/jira/browse/TEXT-153
> Project: Commons Text
> Issue Type: Improvement
> Affects Versions: 1.0
> Reporter: Amir Hadadi
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When using Java Mission Control to profile an application that uses
> StringEscapeUtils::escapeEcmaScript, I noticed that a lot of time is spent in
> LookupTranslator::translate at the prefixSet::contains check.
> I suggest taking advantage of the fact that prefixSet contains only
> characters, and replace it with a BitSet.
> I did some benchmarking and translate for the non escaped case is 4-5X faster
> when replacing the HashSet with a BitSet.
> BitSet Memory consumption for characters is capped at 8KB, and depends on the
> maximal prefix character. For example for ECMA script the max escaped prefix
> character is "\" which has unicode code 92 so the BitSet uses a long array of
> length 2 to represent all the needed characters.
>
> Link to pull request: https://github.com/apache/commons-text/pull/108
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
