[
https://issues.apache.org/jira/browse/TEXT-156?focusedWorklogId=209877&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-209877
]
ASF GitHub Bot logged work on TEXT-156:
---------------------------------------
Author: ASF GitHub Bot
Created on: 08/Mar/19 00:05
Start Date: 08/Mar/19 00:05
Worklog Time Spent: 10m
Work Description: kinow commented on issue #110: TEXT-156: Fix the
RegexTokenizer to use a static Pattern.
URL: https://github.com/apache/commons-text/pull/110#issuecomment-470751304
I think it's only Travis having a network hiccup @aherbert . Feel free to do
the honours if you'd like and merge/update changes.xml/jira 🙂 and thanks for
the PR!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 209877)
Time Spent: 1h 10m (was: 1h)
> Fix the RegexTokenizer to use a static Pattern
> ----------------------------------------------
>
> Key: TEXT-156
> URL: https://issues.apache.org/jira/browse/TEXT-156
> Project: Commons Text
> Issue Type: Improvement
> Affects Versions: 1.6
> Reporter: Alex D Herbert
> Priority: Trivial
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Use of a static pattern avoids the compile step for each invocation. The
> matcher created from the pattern contains all state so the pattern can be
> used across threads.
> Also:
> * Remove the use of CharSequence.toString() to pass to the
> matcher(CharSequence) method. There is no need to create a String.
> * Fix the javadoc header @code tag.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
