Philip Hodges created COLLECTIONS-712:
-----------------------------------------
Summary: ExtendedProperties.save swallows instead of throwing
IOException
Key: COLLECTIONS-712
URL: https://issues.apache.org/jira/browse/COLLECTIONS-712
Project: Commons Collections
Issue Type: Bug
Components: Properties
Affects Versions: 3.2.2
Reporter: Philip Hodges
commons-collections-3.2.2-src/src/java/org/apache/commons/collections/ExtendedProperties.java
/**
* Save the properties to the given output stream.
* ...
* @throws IOException if an IO error occurs - no it does not.
*/
public synchronized void save(OutputStream output, String header) throws
IOException {
...
PrintWriter theWrtr = new PrintWriter(output);
// ... after theWrter.flush(); missing if (theWrtr.errorCheck()) throw new
IOException();
Impact: caller cannot tell if the properties were completely saved, perhaps the
disk filled up instead. Missing errorCheck is an antipattern for PrintWriter
and PrintStream.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
