jochenw commented on issue #414: LANG-1369: Formatted and Paramaterized Exception Classes URL: https://github.com/apache/commons-lang/pull/414#issuecomment-476283146 Would you please be so kind, and suggest a use case, which your pr is going to address. Cause, I don't see it immediately. Also a suggestion: Out in the wild, there are quite a number of Pattern format styles, including, for example Hi, guys, my name is {}. Hi, guys, my name is %s. Hi, guys, my name is %1. (Sure, a bit of digging would reveal others.) So, I would suggest, that 1. You replace the PatternFormatter with an interface, and a default implementation. 2. You replace the static ExceptionFactory with instance methods, that use a configurable instance. The static methods might be reimplemented using an instance of the default implementation.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
