milaKisialiova commented on a change in pull request #112: Text 158
URL: https://github.com/apache/commons-text/pull/112#discussion_r270361589
##########
File path:
src/test/java/org/apache/commons/text/similarity/JaccardDistanceTest.java
##########
@@ -37,7 +37,7 @@ public static void setUp() {
@Test
public void testGettingJaccardDistance() {
// Expected Jaccard distance = 1.0 - (intersect / union)
Review comment:
Sorry @garydgregory , I'm still not convinced.
Intersection of two empty sets is empty set, union is also empty set. They
are equal. So Jaccard similarity is 1. And therefore distance is 0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
