garydgregory commented on a change in pull request #44: More efficient
comparison in FileExtensionSelector
URL: https://github.com/apache/commons-vfs/pull/44#discussion_r270672262
##########
File path:
commons-vfs2/src/main/java/org/apache/commons/vfs2/FileExtensionSelector.java
##########
@@ -57,9 +61,7 @@ public FileExtensionSelector(final Collection<String>
extensions) {
* @param extensions The extensions to be included by this selector.
*/
public FileExtensionSelector(final String... extensions) {
- if (extensions != null) {
- this.extensions.addAll(Arrays.asList(extensions));
- }
+ this(Arrays.asList(extensions));
Review comment:
+1 to reusing the ctor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
