[ 
https://issues.apache.org/jira/browse/FILEUPLOAD-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822219#comment-16822219
 ] 

Eric Norman commented on FILEUPLOAD-293:
----------------------------------------

[[email protected]] I understand, but I would argue that unnecessarily 
changing the behavior of the previous release is in fact a serious problem that 
would warrant releasing an official fix.  Downstream consumers expect to be 
able to plug in the new release without having to rewrite their existing code 
and do this regression dance.

> FileExistsException: Destination .. already exists when DiskFileItem.write 
> was given an existing file
> -----------------------------------------------------------------------------------------------------
>
>                 Key: FILEUPLOAD-293
>                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-293
>             Project: Commons FileUpload
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Mladen Girazovski
>            Assignee: Jochen Wiedmann
>            Priority: Major
>             Fix For: Nightly Builds
>
>
> Since 1.4, where FILEUPLOAD-248 was shipped, passing an existing file to 
> DiskFileItem.write will cause an FileExistsException with the message 
> "Destination FILE already exist", this prevents us from upgrading to 1.4 from 
> 1.3.3.
>  
> {{2019-02-20 01:12:56,504 http-nio-2990-exec-3 ERROR 
> [|5ccb9b99-a96f-42ba-ad01-ac278516e1a4|] 
> [IssueAttachmentsResource.privacy-safe] Error saving attachment}}
> {{org.apache.commons.io.FileExistsException: Destination 
> '/buildeng/bamboo-agent-home/xml-data/build-dir/CLOUDRELEASE-AGILEWD15421-FT18/jira-test-runner-jira/target/cargo/configurations/tomcat9x/temp/attachment-3404789743778163937.tmp'
>  already exists}}
> {{ at org.apache.commons.io.FileUtils.moveFile(FileUtils.java:3001)}}
> {{ at 
> org.apache.commons.fileupload.disk.DiskFileItem.write(DiskFileItem.java:405)}}
> {{ at 
> com.atlassian.plugins.rest.common.multipart.fileupload.CommonsFileUploadFilePart.write(CommonsFileUploadFilePart.java:49)}}
> {{ at 
> com.atlassian.jira.rest.v2.issue.IssueAttachmentsResource.getFileFromFilePart(IssueAttachmentsResource.java:175)}}
> {{...}}
>  
> Apache Felix also ran into the same bug:
> https://issues.apache.org/jira/browse/FELIX-6037 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to