garydgregory commented on issue #36: fix for VFS-662: SftpFileSystem has Thread-safe issue about idleChannel URL: https://github.com/apache/commons-vfs/pull/36#issuecomment-487372176 Hi All: Combining DCL and volatile still does not get it right in the current state of this patch since the `Session` is not volatile. While I appreciate the pragmatic approach this patch takes, the fact that it works _for now_ for @qxo is not the complete solution IMO. Would it not be simpler and therefore less bug prone and easier to maintain to synchronize the get and put methods? Granted this is more expensive. Providing finer grain locking as this patch attempts needs to account for all cases, which would be nice to have. Thoughts? @qxo : May you rebase this patch on master please?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
