garydgregory commented on issue #52: VFS-686: webdav4 provider based on the 
latest Jackrabbit 2.x
URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-488096381
 
 
   @woonsan Thank you.
   
   WRT the patch. could there might still be conflicts:
   ```
   C:\git\commons-vfs>git apply \temp\52.patch.txt
   /temp/52.patch.txt:1685: trailing whitespace.
   /*
   /temp/52.patch.txt:1686: trailing whitespace.
    * Licensed to the Apache Software Foundation (ASF) under one or more
   /temp/52.patch.txt:1687: trailing whitespace.
    * contributor license agreements.  See the NOTICE file distributed with
   /temp/52.patch.txt:1688: trailing whitespace.
    * this work for additional information regarding copyright ownership.
   /temp/52.patch.txt:1689: trailing whitespace.
    * The ASF licenses this file to You under the Apache License, Version 2.0
   error: patch failed: pom.xml:179
   error: pom.xml: patch does not apply
   error: patch failed: pom.xml:554
   error: pom.xml: patch does not apply
   error: patch failed: pom.xml:36
   error: pom.xml: patch does not apply
   error: patch failed: pom.xml:194
   error: pom.xml: patch does not apply
   error: patch failed: pom.xml:194
   error: pom.xml: patch does not apply
   error: patch failed: pom.xml:194
   error: pom.xml: patch does not apply
   ```
   
   Can you try to apply the patch locally to your master to see what happens? 
   
   I wanted to review it in Eclipse instead of here...
   
   Thank you!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to