[
https://issues.apache.org/jira/browse/JXPATH-180?focusedWorklogId=235979&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-235979
]
ASF GitHub Bot logged work on JXPATH-180:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/19 20:42
Start Date: 01/May/19 20:42
Worklog Time Spent: 10m
Work Description: markt-asf commented on pull request #11: JXPATH-180 Use
existing reference to BeanInfo
URL: https://github.com/apache/commons-jxpath/pull/11
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 235979)
Time Spent: 10m
Remaining Estimate: 50m (was: 1h)
> BeanPointer.isLeaf calls JXPathIntrospector.getBeanInfo but already has the
> BeanInfo
> ------------------------------------------------------------------------------------
>
> Key: JXPATH-180
> URL: https://issues.apache.org/jira/browse/JXPATH-180
> Project: Commons JXPath
> Issue Type: Improvement
> Reporter: Michele Vivoda
> Priority: Minor
> Labels: locking, performance
> Original Estimate: 1h
> Time Spent: 10m
> Remaining Estimate: 50m
>
> BeanPointer.isLeaf() calls JXPathIntrospector.getBeanInfo to get the BeanInfo
> for the managed class but already has the BeanInfo as a field, passed in
> constructor. Constructor callers (2) obtain it in the same way as done in
> isLeaf().
> So this code:
> return value == null ||
> JXPathIntrospector.getBeanInfo(value.getClass()).isAtomic();
> should be
> return value == null || this.beanInfo.isAtomic()
> https://github.com/apache/commons-jxpath/blob/trunk/src/java/org/apache/commons/jxpath/ri/model/beans/BeanPointer.java#L103
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
