[
https://issues.apache.org/jira/browse/VFS-663?focusedWorklogId=235993&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-235993
]
ASF GitHub Bot logged work on VFS-663:
--------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/19 20:45
Start Date: 01/May/19 20:45
Worklog Time Spent: 10m
Work Description: markt-asf commented on pull request #37: VFS-663 Fixes
proxyUser and proxyPassword not being set in HTTP and S…
URL: https://github.com/apache/commons-vfs/pull/37
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 235993)
Time Spent: 10m
Remaining Estimate: 0h
> SftpClientFactory does not pass proxyUser or proxyPassword to
> non-PROXY_STREAM types
> ------------------------------------------------------------------------------------
>
> Key: VFS-663
> URL: https://issues.apache.org/jira/browse/VFS-663
> Project: Commons VFS
> Issue Type: Bug
> Affects Versions: 2.1, 2.2
> Reporter: Will Buck
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I've discovered that while version 2.1 added `setProxyUser` and
> `setProxyPassword` to `SftpFileSystemConfigBuilder`, these properties are
> only read via `getProxyUser` and `getProxyPassword` for the `ProxyType`
> `PROXY_STREAM`. They are not, however, used for the other two supported proxy
> types (`PROXY_HTTP` and `PROXY_SOCKS5`)
> The fix for this is reasonably straightforward, as both
> `com.jcraft.jsch.ProxyHTTP` and `com.jcraft.jsch.ProxySOCKS5` support a
> `setUserPasswd` function and utilization of a username and password for
> connection.
> I've created a fork with the changes I would propose to fix the bug, but am
> open to changes with it if I have missed any style guidelines. I am unsure
> how to go about writing a clear test for this and would love some assistance
> in doing so, however I have built the fork and imported it into a project my
> client is working on, and it seems to have solved the issue we were having
> (an exception was being thrown, 'Proxy Authentication Required').
> I would welcome feedback and hope to resolve this issue so that other users
> of the library will be able to connect to authenticated proxies easily!
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
