[
https://issues.apache.org/jira/browse/VFS-624?focusedWorklogId=235990&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-235990
]
ASF GitHub Bot logged work on VFS-624:
--------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/19 20:45
Start Date: 01/May/19 20:45
Worklog Time Spent: 10m
Work Description: markt-asf commented on pull request #17: [VFS-624]
fixed LocalFileRandomAccessContent error in read() for 0xFF
URL: https://github.com/apache/commons-vfs/pull/17
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 235990)
Time Spent: 10m
> LocalFileRandomAccessContent returning wrong value when reading 0xFF
> --------------------------------------------------------------------
>
> Key: VFS-624
> URL: https://issues.apache.org/jira/browse/VFS-624
> Project: Commons VFS
> Issue Type: Bug
> Affects Versions: 2.0, 2.1
> Reporter: David Goitia Amigo
> Priority: Critical
> Labels: easyfix
> Original Estimate: 0h
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The LocalFileRandomAccessContent InputStream used for reading a byte as an
> int is calling the RandomAccessFile method readByte(byte), so it returns -1
> in case of EOFException, but also in case of reading 0xFF in a file.
> This also violates the expected behaviour of the read() method of the
> InputStream as can return negative values as result of the casting, while
> should only return an int value beetween 0 and 255, or -1 in case of eof.
> This problem is also inherited by the default read(byte[]) and read(byte[],
> int off, int length).
> The solution is to change the implementation to:
> raf.read();
> Pull request: https://github.com/apache/commons-vfs/pull/17
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
