Tibor17 commented on a change in pull request #78: COMPRESS-485 keep zip
entries order in parallel zip creation
URL: https://github.com/apache/commons-compress/pull/78#discussion_r283115500
##########
File path:
src/main/java/org/apache/commons/compress/archivers/zip/ParallelScatterZipCreator.java
##########
@@ -255,8 +257,13 @@ public void writeTo(final ZipArchiveOutputStream
targetStream)
compressionDoneAt = System.currentTimeMillis();
synchronized (streams) {
+ // write zip entries in the order they were added (kept as
futures)
+ for (final Future<ScatterZipOutputStream> future : futures) {
Review comment:
see the pr #79
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services