[
https://issues.apache.org/jira/browse/COMPRESS-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838036#comment-16838036
]
Stefan Bodewig commented on COMPRESS-485:
-----------------------------------------
I'm sorry I'm not as active right now around here as I used to, and I don't
expect that to change too soon. The person most familiar with the code in
question is [~krosenvold].
To be honest I'd like to take a step backwards before I have even looked at any
of the PRs. Parallel processing of entries and keeping the entries in order
looks like somewhat competing goals and most users of Commons Compress will not
need both of them. I'm not convinced we should augment the default for parallel
processing with logic to keep entry order if it adds complexity or slows things
down for those who don't care about entry order.
As I said I haven't looked at the PRs at all but would ask you to be open to
approaches that solve the specific goals in a separate implementation from the
default one.
> Reproducible Builds: keep entries order when gathering ScatterZipOutputStream
> content in ParallelScatterZipCreator
> ------------------------------------------------------------------------------------------------------------------
>
> Key: COMPRESS-485
> URL: https://issues.apache.org/jira/browse/COMPRESS-485
> Project: Commons Compress
> Issue Type: Improvement
> Components: Archivers
> Affects Versions: 1.18
> Reporter: Hervé Boutemy
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> currently, zip files created using ParallelScatterZipCreator have random
> order.
> This is causing issues when trying to do Reproducible Builds with Maven
> MNG-6276
> Studying ParallelScatterZipCreator, entries are kept sorted in memory in
> futures list: instead of writing each full scatter in sequence, iterating
> over futures should permit to write each zip entry in original order, without
> changing the API or any performance of the gathering process
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
