[
https://issues.apache.org/jira/browse/IMAGING-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838702#comment-16838702
]
Joakim Knudsen commented on IMAGING-221:
----------------------------------------
Thanks a lot! It's very reassuring to know that the output/edited image
validates OK when using Imaging!
However, I'm still a bit worried about how the meta data is restructured during
edit. Are you able to easily run [the example code which sets GPS
coordinates|https://apache.googlesource.com/sanselan/+/e3b28b1c83ed93ce763e59afbbf5d2dba86901fb/src/test/java/org/apache/commons/sanselan/examples/WriteExifMetadataExample.java],
and see if this code changes that specific tag without affecting all the
remaining contents?
> updateExifMetadataLossless restructures meta data (and problems with Maker
> Notes)
> ---------------------------------------------------------------------------------
>
> Key: IMAGING-221
> URL: https://issues.apache.org/jira/browse/IMAGING-221
> Project: Commons Imaging
> Issue Type: Bug
> Reporter: Joakim Knudsen
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Fix For: 1.0-alpha2
>
> Attachments: original.JPG, original.html, test.JPG, test.html
>
>
> ExifRewriter's *updateExifMetadataLossless* method causes the meta data of
> the JPEG to be completely reordered after writing. This, in itself, might not
> be a big concern, but it's a bit unexpected when the method is named
> "lossless". More worryingly, I also find problems are introduced wrt. the
> Maker Notes tag (odd offset).
> I've produced an example of the problem in the attached JPEG file, using
> ExifTool to validate/analyze the images before and after. The image is taken
> by a Sony Xperia Z5 phone, and the "original.JPG" validates OK. After
> modifying the contents of the UserComments tag (value: "Test") the modified
> image produces a warning:
> Verifying the attached photo using ExifTool gives the following output:
> $ ./exiftool\(-k\).exe -validate -warning -a ../test.JPG
> -- press RETURN --
>
> Validate : 1 Warning (all minor)
> Warning : [minor] Possibly incorrect maker notes
> offsets (fix by -628?)
>
> Using ExifTool's -htmldump option, it is easy to see how the meta data has
> been affected.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
