[
https://issues.apache.org/jira/browse/LANG-1406?focusedWorklogId=241507&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-241507
]
ASF GitHub Bot logged work on LANG-1406:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/May/19 04:34
Start Date: 14/May/19 04:34
Worklog Time Spent: 10m
Work Description: geratorres commented on pull request #422: LANG-1406:
avoid StringIndexOutOfBounds exceptions for some cases of …
URL: https://github.com/apache/commons-lang/pull/422#discussion_r283622541
##########
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##########
@@ -5624,12 +5638,17 @@ private static String replace(final String text,
String searchString, final Stri
if (--max == 0) {
break;
}
- end = searchText.indexOf(searchString, start);
+ end = indexOf(text, searchString, start, ignoreCase);
}
buf.append(text, start, text.length());
return buf.toString();
}
+ private static int indexOf(String str, String searchStr, int fromIndex,
boolean ignoreCase) {
Review comment:
java doc suggestions are welcome
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 241507)
Time Spent: 1h 10m (was: 1h)
> StringIndexOutOfBoundsException in StringUtils.replaceIgnoreCase
> ----------------------------------------------------------------
>
> Key: LANG-1406
> URL: https://issues.apache.org/jira/browse/LANG-1406
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.*
> Reporter: Michael Ryan
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> STEPS TO REPRODUCE:
> {code}
> StringUtils.replaceIgnoreCase("\u0130x", "x", "")
> {code}
> EXPECTED: "\u0130" is returned.
> ACTUAL: StringIndexOutOfBoundsException
> This happens because the replace method is assuming that text.length() ==
> text.toLowerCase().length(), which is not true for certain characters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)