[ 
https://issues.apache.org/jira/browse/IMAGING-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840628#comment-16840628
 ] 

Gary Gregory commented on IMAGING-225:
--------------------------------------

Hello [~pauldaustin],

If we make this method public, we need, IMO better Javadocs: Is the array a 
copy or the real underlying array? IOW, if you modify an element of the array 
should it affect the image parser? Feel free to propose a PR on GitHub :) This 
is the same kind of issue we see a lot of warnings about in the site reports 
WRT to byte arrays and other arrays. The minimum would be to document the 
current implementation I would imagine. Do you have any thoughts here 
[~pauldaustin]? Any one else?

Gary

> Make ImageParser.getAcceptedExtensions public
> ---------------------------------------------
>
>                 Key: IMAGING-225
>                 URL: https://issues.apache.org/jira/browse/IMAGING-225
>             Project: Commons Imaging
>          Issue Type: Improvement
>          Components: imaging.*
>    Affects Versions: 1.0-alpha1
>            Reporter: Paul Austin
>            Priority: Trivial
>
> Would it be possible to make ImageParser.getAcceptedExtensions public?
> This way filters can be created in a file selection dialog in a UI. Or for 
> other purposes linking the ImageParser for the file extensions associated 
> with that ImageParser.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to