kinow commented on a change in pull request #38: Cleaned up PNG component.
URL: https://github.com/apache/commons-imaging/pull/38#discussion_r284485902
 
 

 ##########
 File path: 
src/main/java/org/apache/commons/imaging/formats/png/PngImageParser.java
 ##########
 @@ -622,7 +577,9 @@ public BufferedImage getBufferedImage(final ByteSource 
byteSource, Map<String, O
 
             ScanExpediter scanExpediter;
 
-            switch (pngChunkIHDR.interlaceMethod) {
+            // Note that here we assume the only filter method. Hence, the
+            // filtering and interlacing are combined (correct??)
 
 Review comment:
   For this note a `TODO` is probably better, as the IDE/static analyzers may 
tell other developers about it. And remind them to revisit this every now and 
then.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to