[
https://issues.apache.org/jira/browse/IMAGING-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843136#comment-16843136
]
Joakim Knudsen edited comment on IMAGING-221 at 5/18/19 10:57 AM:
------------------------------------------------------------------
[~kinow], could you please re-run the GPS experiment using the "original.jpg"
file? I'd like to compare the structure of the original photo produced by my
Xperia, to the resulting file of the sample code. So, perhaps name the file
just "sample-gps.jpg"?
As I understand your previous comment, you ran the GPS experiment on the
"mine.JPG" file, which was the output of my code adding the ImageDescription
and UserComments tags (contents: "This is a test comment"). However, in the
resulting "mine-gps.jpg" file, after adding the GPS coordinates, it seems "my"
comment tags have been removed! This, in itself, is unsettling as the sample
code uses a method specifically named
`ExifRewriter().updateExifMetadataLossless`.
Please see attached screenshot, tagsmissing.png
was (Author: joakimk):
[~kinow], could you please re-run the GPS experiment using the "original.jpg"
file? I'd like to compare the structure of the original photo produced by my
Xperia, to the resulting file of the sample code. So, perhaps name the file
just "sample-gps.jpg"?
As I understand your previous comment, you ran the GPS experiment on the
"mine.JPG" file, which was the output of my code adding the ImageDescription
and UserComments tags (contents: "This is a test comment"). However, in the
resulting "mine-gps.jpg" file, after adding the GPS coordinates, it seems "my"
comment tags have been removed! This, in itself, is unsettling as the sample
code uses a method specifically named
`ExifRewriter().updateExifMetadataLossless`.
> updateExifMetadataLossless restructures meta data (and problems with Maker
> Notes)
> ---------------------------------------------------------------------------------
>
> Key: IMAGING-221
> URL: https://issues.apache.org/jira/browse/IMAGING-221
> Project: Commons Imaging
> Issue Type: Bug
> Reporter: Joakim Knudsen
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Fix For: 1.0-alpha2
>
> Attachments: mine-gps.JPG, mine-metadata.JPG, mine-original.JPG,
> mine.JPG, mine.JPG.html, original.JPG, original.html, tagsmissing.png,
> test.JPG, test.html
>
>
> ExifRewriter's *updateExifMetadataLossless* method causes the meta data of
> the JPEG to be completely reordered after writing. This, in itself, might not
> be a big concern, but it's a bit unexpected when the method is named
> "lossless". More worryingly, I also find problems are introduced wrt. the
> Maker Notes tag (odd offset).
> I've produced an example of the problem in the attached JPEG file, using
> ExifTool to validate/analyze the images before and after. The image is taken
> by a Sony Xperia Z5 phone, and the "original.JPG" validates OK. After
> modifying the contents of the UserComments tag (value: "Test") the modified
> image produces a warning:
> Verifying the attached photo using ExifTool gives the following output:
> $ ./exiftool\(-k\).exe -validate -warning -a ../test.JPG
> -- press RETURN --
>
> Validate : 1 Warning (all minor)
> Warning : [minor] Possibly incorrect maker notes
> offsets (fix by -628?)
>
> Using ExifTool's -htmldump option, it is easy to see how the meta data has
> been affected.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
