[
https://issues.apache.org/jira/browse/MATH-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843246#comment-16843246
]
Gilles commented on MATH-1484:
------------------------------
bq. Should I still create the pull request for this project?
No; it should be fixed in "Commons Numbers".
bq. It seems to me that, if the class exists in this project, there is no
reason not to fix the bug.
According to the current plan, this class won't exist in the next release of
"Commons Math" (because, as said, the functionality has been moved already).
> Fraction.add(int) and Fraction.subtract(int) ignore risk of integer overflow
> ----------------------------------------------------------------------------
>
> Key: MATH-1484
> URL: https://issues.apache.org/jira/browse/MATH-1484
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 3.6.1
> Reporter: Heinrich Bohne
> Priority: Minor
>
> The methods {{add(int)}} and {{subtract(int)}} in the class
> {{org.apache.commons.math4.fraction.Fraction.java}} do not take into account
> the risk of an integer overflow. For example, (2^31^ - 1)/2 + 1 = (2^31^ +
> 1)/2, so the numerator overflows an {{int}}, but when calculated with
> {{Fraction.add(int)}}, the method still returns normally.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
