garydgregory commented on issue #26: [BCEL-317] Pluggable cache for ConstantUtf8 URL: https://github.com/apache/commons-bcel/pull/26#issuecomment-496911265 Hi @suztomo I can appreciate the desire to provide a PR with a narrow footprint, but we must take semantics into account here. My basic issue is still that we have two public APIs, one that says "give me an instance" and the other that says "give me a cached instance". This to me implies that the former never returns a cached instance and it currently does not indeed. The latter always returns a cached instance, but in fact only tries to do so by enforcing a cache size limit. It feels like this PR is trying to force caching on clients that use getInstance() instead of properly calling getCachedInstance(). If the client is BCEL itself, then we need to address using BCEL in a caching vs. not mode.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
