michael-o commented on a change in pull request #4: add
JAVA_1_10_HOME,JAVA_1_11_HOME,JAVA_1_12_HOME into _removeheaders in
maven-bundle-plugin
URL: https://github.com/apache/commons-parent/pull/4#discussion_r289651797
##########
File path: pom.xml
##########
@@ -627,7 +627,7 @@
<!-- stops the "uses" clauses being added to "Export-Package"
manifest entry -->
<_nouses>true</_nouses>
<!-- Stop the JAVA_1_n_HOME variables from being treated as
headers by Bnd -->
-
<_removeheaders>JAVA_1_3_HOME,JAVA_1_4_HOME,JAVA_1_5_HOME,JAVA_1_6_HOME,JAVA_1_7_HOME,JAVA_1_8_HOME,JAVA_1_9_HOME</_removeheaders>
+
<_removeheaders>JAVA_1_3_HOME,JAVA_1_4_HOME,JAVA_1_5_HOME,JAVA_1_6_HOME,JAVA_1_7_HOME,JAVA_1_8_HOME,JAVA_1_9_HOME,JAVA_1_10_HOME,JAVA_1_11_HOME,JAVA_1_12_HOME</_removeheaders>
Review comment:
Where are these headers used? There is no Java 1.9, 1.10 and so on. These
symbols are incorrect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
