XenoAmess commented on issue #429: ArrayUtils: merge 8 isSameLength,isEmpty,isNotEmpty into one function each. URL: https://github.com/apache/commons-lang/pull/429#issuecomment-498867087 > Wouldn't it allow for `ArrayUtils.isSameLength("this is a test", "a test this is")`? Which would actually result in `IllegalArgumentException` in `getLength`, but could be misleading. > > IMHO, the current way is better, or if someone could come up with a simplification using generics, that could work too. But using `Object` changes the semantics of the method - and not exactly in an intuitive way. Then I wonder, why ArrayUtils.getLength accept an Object as param then? Shouldn't it become 8 functions just like isSameLength?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
