LuckyIlam commented on issue #34: Added support duplicate header entries URL: https://github.com/apache/commons-csv/pull/34#issuecomment-499110632 > Please provide a separate PR if you find a problem as we just released 1.7 but the site has not been updated yet. Could you just take a minute to look that code, is it normal that there is ` // validate header if (header != null) { final Set<String> dupCheck = new HashSet<>(); for (final String hdr : header) { if (!dupCheck.add(hdr)) { throw new IllegalArgumentException( "The header contains a duplicate entry: '" + hdr + "' in " + Arrays.toString(header)); } } } ` and not ` // validate header if (header != null && !allowDuplicateHeaderNames) { final Set<String> dupCheck = new HashSet<>(); for (final String hdr : header) { if (!dupCheck.add(hdr)) { throw new IllegalArgumentException( "The header contains a duplicate entry: '" + hdr + "' in " + Arrays.toString(header)); } } } `
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
