[
https://issues.apache.org/jira/browse/NUMBERS-113?focusedWorklogId=255264&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-255264
]
ASF GitHub Bot logged work on NUMBERS-113:
------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jun/19 17:20
Start Date: 06/Jun/19 17:20
Worklog Time Spent: 10m
Work Description: Schamschi commented on pull request #50: NUMBERS-113:
Fix JUnit dependencies in pom.xml
URL: https://github.com/apache/commons-numbers/pull/50
I'm not a JUnit expert, so I'm not sure if this is the optimal way to import
both JUnit 5 and JUnit 4. But it does seem to solve the problems described in
the JIRA ticket, so I'll just be bold and put this here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 255264)
Time Spent: 10m
Remaining Estimate: 0h
> Broken/deprecated/old JUnit dependencies in pom.xml
> ---------------------------------------------------
>
> Key: NUMBERS-113
> URL: https://issues.apache.org/jira/browse/NUMBERS-113
> Project: Commons Numbers
> Issue Type: Bug
> Reporter: Heinrich Bohne
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The recent
> [commit|https://github.com/apache/commons-numbers/commit/999935b53cff1a9fc8c9a5b4a44bd33d22c959c4]
> where JUnit 5 was introduced seems to have broken something. Apparently, the
> version number for the junit-platform-runner dependency (version 5.0.0-M4)
> does not exist.
> Also, the latest stable version of junit-jupiter-engine is 5.4.2, but the
> pom.xml declares a version number 5.0.0-M4 also for this dependency.
> Besides, I'm getting a warning when trying to run tests:
> bq. The junit-platform-surefire-provider has been deprecated and is scheduled
> to be removed in JUnit Platform 1.4. Please use the built-in support in Maven
> Surefire >= 2.22.0 instead.
> I'm not sure what this means, but I assume it has something to do with the
> dependencies configured for the surefire plugin, which were not there before.
> Besides, I think the appropriate scope for the junit-jupiter-engine
> dependency is {{test}} (currently, it is not set, so it defaults to
> {{compile}}).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
