grimreaper commented on issue #48: [WIP] perform the actual migration to JUnit 5 URL: https://github.com/apache/commons-numbers/pull/48#issuecomment-499861252 > but the next time you do this, could you please first update your local copy of the branch? I think I figured out what I did wrong: my branch was set up to track origin/master instead of our working branch. thus, when I did `git pull` it didn't actually do what I wanted. > because in some cases the merge from the fraction-dev branch to the master branch caused the test methods to invoke different methods/constructors than before, ... I think I have fixed these issues now with my latest commit. Thank you. Right now the only things failing are ``` [ERROR] /Users/eax/svn/apache/commons/numbers/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/LinearCombinationTest.java:[39,29] incompatible types: long cannot be converted to java.math.BigInteger [ERROR] /Users/eax/svn/apache/commons/numbers/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/LinearCombinationTest.java:[40,29] incompatible types: long cannot be converted to java.math.BigInteger [ERROR] /Users/eax/svn/apache/commons/numbers/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/LinearCombinationTest.java:[41,29] incompatible types: long cannot be converted to java.math.BigInteger [ERROR] /Users/eax/svn/apache/commons/numbers/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/LinearCombinationTest.java:[44,29] incompatible types: long cannot be converted to java.math.BigInteger [ERROR] /Users/eax/svn/apache/commons/numbers/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/LinearCombinationTest.java:[45,29] incompatible types: long cannot be converted to java.math.BigInteger [ERROR] /Users/eax/svn/apache/commons/numbers/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/LinearCombinationTest.java:[46,29] incompatible types: long cannot be converted to java.math.BigInteger [ERROR] -> [Help 1] ```` which I'm looking at now
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
