[
https://issues.apache.org/jira/browse/IMAGING-134?focusedWorklogId=256362&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-256362
]
ASF GitHub Bot logged work on IMAGING-134:
------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jun/19 03:54
Start Date: 08/Jun/19 03:54
Worklog Time Spent: 10m
Work Description: kinow commented on pull request #47: IMAGING-134: Fix
JPEG handling for files encoded with RST markers
URL: https://github.com/apache/commons-imaging/pull/47#discussion_r291792933
##########
File path:
src/main/java/org/apache/commons/imaging/formats/jpeg/decoder/JpegInputStream.java
##########
@@ -15,31 +15,39 @@
package org.apache.commons.imaging.formats.jpeg.decoder;
-import java.io.IOException;
-import java.io.InputStream;
-
import org.apache.commons.imaging.ImageReadException;
import org.apache.commons.imaging.formats.jpeg.JpegConstants;
class JpegInputStream {
// Figure F.18, F.2.2.5, page 111 of ITU-T T.81
- private final InputStream is;
+ private final int[] interval;
+ // next position in the array to read
+ private int nextPos;
private int cnt;
private int b;
- JpegInputStream(final InputStream is) {
- this.is = is;
+ JpegInputStream(final int[] interval) {
+ this.interval = interval;
Review comment:
`this.interval = Arrays.copyOf(interval, interval.length);` to prevent
mutability issues? Not sure if there is any risk (i.e. if internal only,
probably not at risk, but may be still a good idea to play defensively here)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 256362)
Time Spent: 1.5h (was: 1h 20m)
> Invalid marker found in entropy data
> ------------------------------------
>
> Key: IMAGING-134
> URL: https://issues.apache.org/jira/browse/IMAGING-134
> Project: Commons Imaging
> Issue Type: Bug
> Components: Format: JPEG
> Affects Versions: 1.0-alpha1
> Reporter: John Hewson
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Fix For: Patch Needed
>
> Attachments: image.jpeg
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> I'm getting the following exception when trying to read a JPEG:
> Exception in thread "main" org.apache.commons.imaging.ImageReadException:
> Invalid marker found in entropy data
> at
> org.apache.commons.imaging.formats.jpeg.decoder.JpegInputStream.nextBit(JpegInputStream.java:50)
> at
> org.apache.commons.imaging.formats.jpeg.decoder.JpegDecoder.decode(JpegDecoder.java:426)
> at
> org.apache.commons.imaging.formats.jpeg.decoder.JpegDecoder.readMCU(JpegDecoder.java:320)
> at
> org.apache.commons.imaging.formats.jpeg.decoder.JpegDecoder.visitSOS(JpegDecoder.java:124)
> at
> org.apache.commons.imaging.formats.jpeg.JpegUtils.traverseJFIF(JpegUtils.java:80)
> at
> org.apache.commons.imaging.formats.jpeg.decoder.JpegDecoder.decode(JpegDecoder.java:436)
> at
> org.apache.commons.imaging.formats.jpeg.JpegImageParser.getBufferedImage(JpegImageParser.java:98)
> at
> org.apache.commons.imaging.Imaging.getBufferedImage(Imaging.java:1378)
> at
> org.apache.commons.imaging.Imaging.getBufferedImage(Imaging.java:1341)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
