Heinrich Bohne created NUMBERS-117:
--------------------------------------
Summary: Redundant methods in several TestUtils classes
Key: NUMBERS-117
URL: https://issues.apache.org/jira/browse/NUMBERS-117
Project: Commons Numbers
Issue Type: Improvement
Reporter: Heinrich Bohne
The following methods from the class {{TestUtils}} in the module
_commons-numbers-core_ are redundant:
|{{assertEquals(double, double, double)}}|{{Assertions.assertEquals(double,
double, double)}} already considers two {{NaN}} values equal, so the two
methods are equivalent.|
|{{assertEquals(String, double, double, double)}}|Equivalent to
{{Assertions.assertEquals(double, double, double, String)}}, as explained above|
|{{assertSame(double, double)}}|Equivalent to {{Assertions.assertEquals(double,
double)}}|
|{{assertEquals(double[], double[], double)}}|Equivalent to
{{Assertions.assertArrayEquals(double[], double[], double)}}|
|{{assertEquals(String, double[], double[], double)}}|Equivalent to
{{Assertions.assertArrayEquals(double[], double[], double, String)}}|
|{{assertEquals(String, float[], float[], float)}}|Equivalent to
{{Assertions.assertArrayEquals(float[], float[], float, String)}}|
Similarly, the following methods from the class {{TestUtils}} in the module
_commons-numbers-complex-streams_ are redundant:
|{{assertEquals(double, double, double)}}|Equivalent to
{{Assertions.assertEquals(double, double, double)}}, as explained above|
|{{assertEquals(String, double, double, double)}}|Equivalent to
{{Assertions.assertEquals(double, double, double, String)}}, as explained above|
|{{assertSame(double[], double[])}}|Equivalent to
{{Assertions.assertArrayEquals(double[], double[])}}|
|{{assertSame(float[], float[])}}|Equivalent to
{{Assertions.assertArrayEquals(float[], float[])}}|
|{{assertSame(double, double)}}|Equivalent to {{Assertions.assertEquals(double,
double)}}|
|{{assertEquals(String, double[], double[], double)}}|Equivalent to
{{Assertions.assertArrayEquals(double[], double[], double, String)}}|
|{{assertEquals(String, float[], float[], float)}}|Equivalent to
{{Assertions.assertArrayEquals(float[], float[], float, String)}}|
|{{equalsIncludingNaN(double, double, double)}}|Equivalent to
{{Precision.equalsIncludingNaN(double, double, double)}}|
Finally, the following methods from the class {{TestUtils}} in the module
_commons-numbers-complex_ are redundant:
|{{assertEquals(double, double, double)}}|Equivalent to
{{Assertions.assertEquals(double, double, double)}}, as explained above|
|{{assertEquals(String, double, double, double)}}|Equivalent to
{{Assertions.assertEquals(double, double, double, String)}}, as explained above|
|{{assertSame(double, double)}}|Equivalent to {{Assertions.assertEquals(double,
double)}}|
|{{assertEquals(double[], double[], double)}}|Equivalent to
{{Assertions.assertArrayEquals(double[], double[], double)}}|
|{{assertEquals(String, double[], double[], double)}}|Equivalent to
{{Assertions.assertArrayEquals(double[], double[], double, String)}}|
|{{assertEquals(String, float[], float[], float)}}|Equivalent to
{{Assertions.assertArrayEquals(float[], float[], float, String)}}|
|{{equalsIncludingNaN(double, double, double)}}|Equivalent to
{{Precision.equalsIncludingNaN(double, double, double)}}|
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
