[
https://issues.apache.org/jira/browse/NUMBERS-117?focusedWorklogId=262651&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-262651
]
ASF GitHub Bot logged work on NUMBERS-117:
------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jun/19 22:09
Start Date: 18/Jun/19 22:09
Worklog Time Spent: 10m
Work Description: Schamschi commented on pull request #53: [NUMBERS-117]
Remove redundant TestUtils methods
URL: https://github.com/apache/commons-numbers/pull/53
This pull request does _not_ conflict with [PR
#52](https://github.com/apache/commons-numbers/pull/52).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 262651)
Time Spent: 10m
Remaining Estimate: 0h
> Redundant methods in several TestUtils classes
> ----------------------------------------------
>
> Key: NUMBERS-117
> URL: https://issues.apache.org/jira/browse/NUMBERS-117
> Project: Commons Numbers
> Issue Type: Improvement
> Reporter: Heinrich Bohne
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The following methods from the class {{TestUtils}} in the module
> _commons-numbers-core_ are redundant:
> |{{assertEquals(double, double, double)}}|{{Assertions.assertEquals(double,
> double, double)}} already considers two {{NaN}} values equal, so the two
> methods are equivalent.|
> |{{assertEquals(String, double, double, double)}}|Equivalent to
> {{Assertions.assertEquals(double, double, double, String)}}, as explained
> above|
> |{{assertSame(double, double)}}|Equivalent to
> {{Assertions.assertEquals(double, double)}}|
> |{{assertEquals(double[], double[], double)}}|Equivalent to
> {{Assertions.assertArrayEquals(double[], double[], double)}}|
> |{{assertEquals(String, double[], double[], double)}}|Equivalent to
> {{Assertions.assertArrayEquals(double[], double[], double, String)}}|
> |{{assertEquals(String, float[], float[], float)}}|Equivalent to
> {{Assertions.assertArrayEquals(float[], float[], float, String)}}|
> Similarly, the following methods from the class {{TestUtils}} in the module
> _commons-numbers-complex-streams_ are redundant:
> |{{assertEquals(double, double, double)}}|Equivalent to
> {{Assertions.assertEquals(double, double, double)}}, as explained above|
> |{{assertEquals(String, double, double, double)}}|Equivalent to
> {{Assertions.assertEquals(double, double, double, String)}}, as explained
> above|
> |{{assertSame(double[], double[])}}|Equivalent to
> {{Assertions.assertArrayEquals(double[], double[])}}|
> |{{assertSame(float[], float[])}}|Equivalent to
> {{Assertions.assertArrayEquals(float[], float[])}}|
> |{{assertSame(double, double)}}|Equivalent to
> {{Assertions.assertEquals(double, double)}}|
> |{{assertEquals(String, double[], double[], double)}}|Equivalent to
> {{Assertions.assertArrayEquals(double[], double[], double, String)}}|
> |{{assertEquals(String, float[], float[], float)}}|Equivalent to
> {{Assertions.assertArrayEquals(float[], float[], float, String)}}|
> |{{equalsIncludingNaN(double, double, double)}}|Equivalent to
> {{Precision.equalsIncludingNaN(double, double, double)}}|
> Finally, the following methods from the class {{TestUtils}} in the module
> _commons-numbers-complex_ are redundant:
> |{{assertEquals(double, double, double)}}|Equivalent to
> {{Assertions.assertEquals(double, double, double)}}, as explained above|
> |{{assertEquals(String, double, double, double)}}|Equivalent to
> {{Assertions.assertEquals(double, double, double, String)}}, as explained
> above|
> |{{assertSame(double, double)}}|Equivalent to
> {{Assertions.assertEquals(double, double)}}|
> |{{assertEquals(double[], double[], double)}}|Equivalent to
> {{Assertions.assertArrayEquals(double[], double[], double)}}|
> |{{assertEquals(String, double[], double[], double)}}|Equivalent to
> {{Assertions.assertArrayEquals(double[], double[], double, String)}}|
> |{{assertEquals(String, float[], float[], float)}}|Equivalent to
> {{Assertions.assertArrayEquals(float[], float[], float, String)}}|
> |{{equalsIncludingNaN(double, double, double)}}|Equivalent to
> {{Precision.equalsIncludingNaN(double, double, double)}}|
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
