Schamschi commented on issue #56: NUMBERS-119: Correct bug in BigFraction(double) constructor URL: https://github.com/apache/commons-numbers/pull/56#issuecomment-504619638 Interesting, the code coverage decreased, but not because of the special case I added for subnormal numbers (this was already covered by a test that only tested the numerator but not the denominator, which is why the test did not fail), but because I also made a special case for zero that caused the denominator of the created fraction to be set to 1 (so that the fraction is 0/1) instead of 2^1075. For some reason, this caused a branch in the method reduce() not to be executed by tests anymore …
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
