nickbabcock commented on issue #115: Fix length change omission for StringSubstitutor cyclic detection URL: https://github.com/apache/commons-text/pull/115#issuecomment-506115877 > I think this would still require a change, as it appears to prevent an error you had (and which users may have as well). Trivial changes are more javadocs, style changes, rename a local variable, fix unused imports, etc. Anything that doesn't affect users regarding backward compatibility (binary or behaviour wise), and also don't add any new feature. It's a logic bug that can't manifest in commons-text is due to the reliance on internal `TextStringBuilder#buffer` and how it's implemented. So the number of users effected by this bug is 0. I only came across the bug when a I needed to apply some changes and created the diff posted above. Let me know if you'd want me to create a JIRA ticket still 😄
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
