[
https://issues.apache.org/jira/browse/NUMBERS-122?focusedWorklogId=268581&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-268581
]
ASF GitHub Bot logged work on NUMBERS-122:
------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jun/19 14:52
Start Date: 27/Jun/19 14:52
Worklog Time Spent: 10m
Work Description: asfgit commented on pull request #59: NUMBERS-122: Make
assertFraction(long, long, BigFraction) compare the…
URL: https://github.com/apache/commons-numbers/pull/59
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 268581)
Time Spent: 0.5h (was: 20m)
> Helper assertion methods in BigFractionTest not strict enough
> -------------------------------------------------------------
>
> Key: NUMBERS-122
> URL: https://issues.apache.org/jira/browse/NUMBERS-122
> Project: Commons Numbers
> Issue Type: Bug
> Components: fraction
> Affects Versions: 1.0
> Reporter: Heinrich Bohne
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The helper methods {{assertFraction(int, int, BigFraction)}} and
> {{assertFraction(long, long, BigFraction)}} don't check whether the numerator
> and denominator of the {{BigFraction}} are equivalent to the first two
> arguments. Rather, they check whether the numerator and denominator
> _truncated to an {{int}} or {{long}}_ are equal to the first two arguments.
> This is unsatisfactory and also probably not in the spirit of the creator of
> these methods.
> Also, the method {{assertFraction(int, int, BigFraction)}} is redundant,
> because an {{int}} can be cast to a {{long}} without loss of precision, so
> {{assertFraction(long, long, BigFraction)}} is sufficient to handle both
> {{int}} and {{long}} arguments.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
