[
https://issues.apache.org/jira/browse/NUMBERS-119?focusedWorklogId=268689&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-268689
]
ASF GitHub Bot logged work on NUMBERS-119:
------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jun/19 17:51
Start Date: 27/Jun/19 17:51
Worklog Time Spent: 10m
Work Description: coveralls commented on issue #56: NUMBERS-119: Correct
bug in BigFraction(double) constructor
URL: https://github.com/apache/commons-numbers/pull/56#issuecomment-504617374
[](https://coveralls.io/builds/24249469)
Coverage decreased (-0.03%) to 94.169% when pulling
**80a5e265eb8e5413e9f63f102a4dc814b07216b1 on Schamschi:NUMBERS-119** into
**b3890a0e5568f554cafff270b19c99dd932a4346 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 268689)
Time Spent: 1h 10m (was: 1h)
> BigFraction(double) constructor does not treat subnormal numbers correctly
> --------------------------------------------------------------------------
>
> Key: NUMBERS-119
> URL: https://issues.apache.org/jira/browse/NUMBERS-119
> Project: Commons Numbers
> Issue Type: Bug
> Components: fraction
> Affects Versions: 1.0
> Reporter: Heinrich Bohne
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The constructor {{BigFraction(double)}} does not take into account the fact
> that, when the biased exponent of a {{double}} value is {{0}} and the
> mantissa is not {{0}} (i.e. when the value represents a subnormal number),
> the actual exponent in effect is not {{-1023}} but {{-1022}} (or, in other
> words, the effective exponent bias is not {{1023}} but {{1022}}).
> The value of the created {{BigFraction}} is therefore not equal to the value
> of the passed {{double}} argument.
> Also, since the constructor does not handle the case of zero separately, it
> creates a fraction with a numerator of 0 and a denominator of 2^1075^, which
> is not very memory-efficient.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
