[
https://issues.apache.org/jira/browse/NUMBERS-123?focusedWorklogId=269920&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-269920
]
ASF GitHub Bot logged work on NUMBERS-123:
------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jul/19 00:07
Start Date: 01/Jul/19 00:07
Worklog Time Spent: 10m
Work Description: coveralls commented on issue #60: NUMBERS-123: Javadoc
URL: https://github.com/apache/commons-numbers/pull/60#issuecomment-507078673
[](https://coveralls.io/builds/24291326)
Coverage remained the same at 94.155% when pulling
**39c83ad03e4cfb4c8d4cf5e855e14eb1c6a62667 on Schamschi:NUMBERS-123** into
**a796401f4a695738ed72512dd2a3920c71d7bb23 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 269920)
Time Spent: 20m (was: 10m)
> "BigFraction(double)" is unnecessary
> ------------------------------------
>
> Key: NUMBERS-123
> URL: https://issues.apache.org/jira/browse/NUMBERS-123
> Project: Commons Numbers
> Issue Type: Improvement
> Components: fraction
> Reporter: Gilles
> Assignee: Gilles
> Priority: Trivial
> Fix For: 1.0
>
> Attachments: NUMBERS-123__Javadoc.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Constructor {{BigFraction(double value)}} is only called from the
> {{from(double value)}} method.
> Actually, this constructor is misleading as it is indeed primarily a
> conversion from which appropriate {{numerator}} and {{denominator}} fields
> are computed; those could be set by
> the "direct" constructor {{BigFraction(BigInteger num, BigInteger den)}}.
> Moreover, the private field {{ZERO}} goes through this conversion code
> whereas it could constructed "directly", e.g. using {{of(0)}}. Similarly for
> field {{ONE}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
