[
https://issues.apache.org/jira/browse/NUMBERS-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876126#comment-16876126
]
Heinrich Bohne commented on NUMBERS-125:
----------------------------------------
With {{BigFraction.reduce()}} gone, {{BigFraction.equals(Object)}} relies on
the fields {{numerator}} and {{denominator}} being reduced to lowest terms, so
this _had_ to be specified in the documentation of those two fields. The
documentation of the public API was unaffected by this.
> BigFraction.reduce() and Fraction.getReducedFraction(int, int) are unnecessary
> ------------------------------------------------------------------------------
>
> Key: NUMBERS-125
> URL: https://issues.apache.org/jira/browse/NUMBERS-125
> Project: Commons Numbers
> Issue Type: Improvement
> Components: fraction
> Affects Versions: 1.0
> Reporter: Heinrich Bohne
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The instance method {{BigFraction.reduce()}} is unnecessary, because the only
> constructor in this class already reduces the fraction to lowest terms.
> Likewise, the static factory method {{Fraction.getReducedFraction(int, int)}}
> is unnecessary, because it is functionally completely equivalent to the
> factory method {{Fraction.of(int, int)}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
