[
https://issues.apache.org/jira/browse/NUMBERS-125?focusedWorklogId=270113&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-270113
]
ASF GitHub Bot logged work on NUMBERS-125:
------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jul/19 12:20
Start Date: 01/Jul/19 12:20
Worklog Time Spent: 10m
Work Description: coveralls commented on issue #61: [NUMBERS-125] Remove
redundant methods BigFraction.reduce() and Fraction.getReducedFraction(int, int)
URL: https://github.com/apache/commons-numbers/pull/61#issuecomment-507241343
[](https://coveralls.io/builds/24300205)
Coverage increased (+0.03%) to 94.184% when pulling
**fbe05a1b79fb9b872666678d8d455cd1be7a0232 on Schamschi:NUMBERS-125** into
**39c83ad03e4cfb4c8d4cf5e855e14eb1c6a62667 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 270113)
Time Spent: 20m (was: 10m)
> BigFraction.reduce() and Fraction.getReducedFraction(int, int) are unnecessary
> ------------------------------------------------------------------------------
>
> Key: NUMBERS-125
> URL: https://issues.apache.org/jira/browse/NUMBERS-125
> Project: Commons Numbers
> Issue Type: Improvement
> Components: fraction
> Affects Versions: 1.0
> Reporter: Heinrich Bohne
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The instance method {{BigFraction.reduce()}} is unnecessary, because the only
> constructor in this class already reduces the fraction to lowest terms.
> Likewise, the static factory method {{Fraction.getReducedFraction(int, int)}}
> is unnecessary, because it is functionally completely equivalent to the
> factory method {{Fraction.of(int, int)}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
