[
https://issues.apache.org/jira/browse/DBCP-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lee Jun Gyun updated DBCP-547:
------------------------------
Description:
It think it would be nice better to implement a ConnectionFactory interface in
BasicDataSource class or implement a interface in DriverConnectionFactory class.
In my current project, when getting a connection in my program, I call
oracleSetModule.
so, i think that after creating connection, call oracleSetModule via
connectionFactoryImpl seems to be nice.
[Before]
protected ConnectionFactory createConnectionFactory() throws SQLException {
...
...
ConnectionFactory driverConnectionFactory =
new DriverConnectionFactory(driverToUse, url, connectionProperties);
return driverConnectionFactory;
}
[After]
protected ConnectionFactory createConnectionFactory() throws SQLException {
...
...
ConnectionFactory driverConnectionFactory =
getConnectionFactoryImpl().newInstance(...);
return driverConnectionFactory;
}
was:
It would be nice to add a ConnectionFactory interface in BasicDataSource class
or add a interface in DriverConnectionFactory class.
In my current project, when getting a connection in my program, I call
oracleSetModule.
so, i think that after creating connection, call oracleSetModule via
connectionFactoryImpl seems to be nice.
[Before]
protected ConnectionFactory createConnectionFactory() throws SQLException {
...
...
ConnectionFactory driverConnectionFactory =
new DriverConnectionFactory(driverToUse, url, connectionProperties);
return driverConnectionFactory;
}
[After]
protected ConnectionFactory createConnectionFactory() throws SQLException {
...
...
ConnectionFactory driverConnectionFactory =
getConnectionFactoryImpl().newInstance(...);
return driverConnectionFactory;
}
> Add a ConnectionFactory Interface in BasicDataSource class
> ----------------------------------------------------------
>
> Key: DBCP-547
> URL: https://issues.apache.org/jira/browse/DBCP-547
> Project: Commons DBCP
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Lee Jun Gyun
> Priority: Minor
>
> It think it would be nice better to implement a ConnectionFactory interface
> in BasicDataSource class or implement a interface in DriverConnectionFactory
> class.
> In my current project, when getting a connection in my program, I call
> oracleSetModule.
> so, i think that after creating connection, call oracleSetModule via
> connectionFactoryImpl seems to be nice.
>
> [Before]
> protected ConnectionFactory createConnectionFactory() throws SQLException {
> ...
> ...
> ConnectionFactory driverConnectionFactory =
> new DriverConnectionFactory(driverToUse, url, connectionProperties);
> return driverConnectionFactory;
> }
> [After]
> protected ConnectionFactory createConnectionFactory() throws SQLException {
> ...
> ...
> ConnectionFactory driverConnectionFactory =
> getConnectionFactoryImpl().newInstance(...);
> return driverConnectionFactory;
> }
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
