leechoongyon opened a new pull request #33: [DBCP-547] Add a ConnectionFactory interface in BasicDataSource.createConnectionFactory() URL: https://github.com/apache/commons-dbcp/pull/33 [DBCP-547] Add a ConnectionFactory interface in BasicDataSource.createConnectionFactory() I think it would be nice better to implement a ConnectionFactory interface in BasicDataSource class. In my current project, when getting a connection in my program, I call oracleSetModule. so, i think that after creating connection, call oracleSetModule via connectionFactoryImpl seems to be nice. This reduces the cost of calling oracleSetModule when calling BasicDataSource.getConnection().
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
