garydgregory commented on a change in pull request #33: [DBCP-547] Add a
ConnectionFactory interface in BasicDataSource.createConnectionFactory()
URL: https://github.com/apache/commons-dbcp/pull/33#discussion_r300066127
##########
File path: src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
##########
@@ -1967,6 +1983,21 @@ public synchronized void setDriverClassName(final
String driverClassName) {
this.driverClassName = null;
}
}
+
+ /**
+ * Sets the ConnectionFactory class name.
+ *
+ * @param connectionFactoryClassName
+ *
+ */
+
+ public void setConnectionFactoryClassName(final String
connectionFactoryClassName) {
+ if (connectionFactoryClassName != null &&
connectionFactoryClassName.trim().length() > 0) {
Review comment:
`connectionFactoryClassName.trim().length() > 0` ->
`!connectionFactoryClassName.trim().isEmpty()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
