[
https://issues.apache.org/jira/browse/NUMBERS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881334#comment-16881334
]
Heinrich Bohne commented on NUMBERS-130:
----------------------------------------
Yes, it does not really matter; to be honest, I just wanted to make the IDE
warnings go away (of course, this does not mean that I would not find a
package-private access preferable over a {{public}} access without the IDE
warnings, since I think it's generally a good idea to reduce scope to the
smallest extent necessary, so it's not like I intended to sacrifice code design
just to shut the IDE up, but I probably wouldn't have cared enough to do
anything about it). But it seems that, in the cases you described, the
practical benefits of leaving the test methods and classes {{public}} outweigh
whatever would be gained from making them package-private (which would be
probably more of a cosmetic nature than anything of real practical use).
> Test classes and methods can be package-private
> -----------------------------------------------
>
> Key: NUMBERS-130
> URL: https://issues.apache.org/jira/browse/NUMBERS-130
> Project: Commons Numbers
> Issue Type: Improvement
> Affects Versions: 1.0
> Reporter: Heinrich Bohne
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> With JUnit 5, test classes and methods don't need to be {{public}}, unlike
> with JUnit 4. It suffices if they are package-private.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
