garydgregory commented on issue #22: CODEC-236: MurmurHash2 and MurmurHash3 implementations. URL: https://github.com/apache/commons-codec/pull/22#issuecomment-510239394 Hm, `XXHash32` and others implements `java.util.zip.Checksum`. Other classes in `org.apache.commons.codec.digest` do _not_ implement Codec interfaces where some could, like `UnixCrypt`. Food for thought. But for the new code in this PR, the fit with the Codec interfaces might not be best. The Travid build (https://travis-ci.org/apache/commons-codec/jobs/556975625) reveals that the Javadoc for the new code is incomplete: ``` [ERROR] /home/travis/build/apache/commons-codec/src/main/java/org/apache/commons/codec/digest/MurmurHash3.java:84: warning: no @param for l0 [ERROR] public static int hash32(long l0, int seed) { [ERROR] ^ [ERROR] /home/travis/build/apache/commons-codec/src/main/java/org/apache/commons/codec/digest/MurmurHash3.java:84: warning: no @param for seed [ERROR] public static int hash32(long l0, int seed) { [ERROR] ^ [ERROR] /home/travis/build/apache/commons-codec/src/main/java/org/apache/commons/codec/digest/MurmurHash3.java:84: warning: no @return [ERROR] public static int hash32(long l0, int seed) { [ERROR] ^ [ERROR] /home/travis/build/apache/commons-codec/src/main/java/org/apache/commons/codec/digest/MurmurHash3.java:97: warning: no @param for l0 [ERROR] public static int hash32(long l0, long l1, int seed) { [ERROR] ^ [ERROR] /home/travis/build/apache/commons-codec/src/main/java/org/apache/commons/codec/digest/MurmurHash3.java:97: warning: no @param for l1 [ERROR] public static int hash32(long l0, long l1, int seed) { [ERROR] ^ [ERROR] /home/travis/build/apache/commons-codec/src/main/java/org/apache/commons/codec/digest/MurmurHash3.java:97: warning: no @param for seed [ERROR] public static int hash32(long l0, long l1, int seed) { [ERROR] ^ [ERROR] /home/travis/build/apache/commons-codec/src/main/java/org/apache/commons/codec/digest/MurmurHash3.java:97: warning: no @return [ERROR] public static int hash32(long l0, long l1, int seed) { [ERROR] ^ [ERROR] /home/travis/build/apache/commons-codec/src/main/java/org/apache/commons/codec/digest/MurmurHash3.java:275: warning: no @param for offset [ERROR] public static long hash64(byte[] data, int offset, int length, int seed) { [ERROR] ^ ``` It would be best if you could address this as well as the decrease in code coverage.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
