[
https://issues.apache.org/jira/browse/CSV-247?focusedWorklogId=281139&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-281139
]
ASF GitHub Bot logged work on CSV-247:
--------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jul/19 16:45
Start Date: 23/Jul/19 16:45
Worklog Time Spent: 10m
Work Description: mykolapolonskyi commented on issue #47: CSV-247:
CSVParser to check an empty header before checking duplicates.
URL: https://github.com/apache/commons-csv/pull/47#issuecomment-514291345
hi there
I've found you PR related to the thing that I've catched - when csv file
doesn't contain the header line I parsing should throw IllegalArgument
Exception
Maybe this test can be added as part of your PR because seems that fix
should be in place that you`ve edited? what do you think?
```
private enum CSVHeaders {
Name;
}
@Test(expected = IllegalArgumentException.class)
public void testMissingHeaderWithEnumConfiguration() throws Exception {
final Reader in = new StringReader("not name");
CSVFormat.DEFAULT.withHeader(CSVHeaders.class).withIgnoreHeaderCase().parse(in).iterator();
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 281139)
Time Spent: 0.5h (was: 20m)
> A single empty header is allowed when not allowing empty column headers.
> ------------------------------------------------------------------------
>
> Key: CSV-247
> URL: https://issues.apache.org/jira/browse/CSV-247
> Project: Commons CSV
> Issue Type: Bug
> Affects Versions: 1.7
> Reporter: Alex D Herbert
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> If the settings are not allowing empty columns headers you can currently use
> a single empty header. This is because column headers are only checked for
> empty when they are duplicates. So it is the second empty header (the first
> duplicate) that raises an error. This test should pass but does not:
> {code:java}
> @Test(expected = IllegalArgumentException.class)
> public void testHeadersMissingOneColumnException() throws Exception {
> final Reader in = new StringReader("a,,c,d\n1,2,3,4\nx,y,z,zz");
> CSVFormat.DEFAULT.withHeader().parse(in).iterator();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
