cljk commented on issue #24: Base64 should be open for different alphabets URL: https://github.com/apache/commons-codec/pull/24#issuecomment-514408171 @aherbert Yes, I can confirm: ``` mvn javadoc:javadoc ``` fails, `mvn` too and ``` mvn javadoc:javadoc -Dsource=1.7 ``` works... But perhaps we should open an issue for that since that´s not caused by my pull request?! --- * added check for encodeTable length ... and a unit test for this check * encode tables `private` again * reintruduced(?) usage of local variable `decodeTable` - needed for successful decoding of data encoded with custom encoding table * for `STANDARD_ENCODE_TABLE` or `URL_SAFE_ENCODE_TABLE` it uses the precalculated `DEFAULT_DECODE_TABLE` as before * for custom encode tables: added a calculation method for decode tables ... and an encode/decode test for a modified encode table " defensive copying of input arrays" - If you think making a duplicate of the encodeTable improves security in any way (?)... adding this would be a one-liner?!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
