[ 
https://issues.apache.org/jira/browse/LANG-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896989#comment-16896989
 ] 

Silence Tai commented on LANG-1462:
-----------------------------------

[~aavanathan]

*{{calendar.getTimeZone()}}* may get it 
{color:red}{{NullPointerException}}{color}.

I think we should leave exceptions to concrete method Implement instead of 
throwing them too early, thus losing internal details.

{code:java}
public static String format(Calendar calendar, String pattern) {
    return format(calendar, pattern, (calendar == null ? null : 
calendar.getTimeZone()), null);
}
{code}


> After version Commons-lang3.4 DateFormatUtils has a bug
> -------------------------------------------------------
>
>                 Key: LANG-1462
>                 URL: https://issues.apache.org/jira/browse/LANG-1462
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.time.*
>    Affects Versions: 3.5, 3.6, 3.7, 3.8, 3.9, 3.8.1
>            Reporter: Lijun Liang
>            Priority: Critical
>
> The code is as follows :
> Calendar cale = Calendar.getInstance();
>  System.out.println("Old time is " + DateFormatUtils.format(cale, 
> "yyyyMMddHHmmss"));
>  cale.setTimeZone(TimeZone.getTimeZone("JST"));
>  System.out.println("New time is " + DateFormatUtils.format(cale, 
> "yyyyMMddHHmmss"));
>  
> The results of commons-lang3 3.4:
> Old time is 20190605144536
> New time is 20190605154536
>  
> The results of the version after commons-lang3 3.4:
> Old time is 20190605144536
> New time is 20190605144536
>  
> We found that the time zone setting was invalidated when it was formatted
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to