[
https://issues.apache.org/jira/browse/IMAGING-168?focusedWorklogId=287590&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-287590
]
ASF GitHub Bot logged work on IMAGING-168:
------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Aug/19 10:22
Start Date: 02/Aug/19 10:22
Worklog Time Spent: 10m
Work Description: kinow commented on pull request #18: IMAGING-168
installing package with Swedish characters adds junk char…
URL: https://github.com/apache/commons-imaging/pull/18#discussion_r310072802
##########
File path:
src/main/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcRecord.java
##########
@@ -38,18 +38,22 @@ public IptcRecord(final IptcType iptcType, final byte[]
bytes, final String valu
this.value = value;
}
- public IptcRecord(final IptcType iptcType, final String value) {
+ public IptcRecord(final IptcType iptcType, final String value, final
String charsetName) {
this.iptcType = iptcType;
byte[] tempBytes;
try {
- tempBytes = value.getBytes("ISO-8859-1");
+ tempBytes = value.getBytes(charsetName);
Review comment:
Overall I think the code looks good to be merged. I would need to find some
spec/docs for reference to clear up a few more questions about the issue.
But the main issue right now are the conflicts. The `tempBytes` was removed
from `IptcRecord`, and now we have only the `String value`. We need to look at
the git history and past issues, and try to understand why it was changed this
way.
Then we can resolve the conflicts and leave it ready to be merged :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 287590)
Time Spent: 2h 10m (was: 2h)
> IPTC parser should use CodedCharacterSet tag to determine encoding of the
> IPTC tag values
> -----------------------------------------------------------------------------------------
>
> Key: IMAGING-168
> URL: https://issues.apache.org/jira/browse/IMAGING-168
> Project: Commons Imaging
> Issue Type: Bug
> Components: Format: JPEG
> Reporter: sudeep khemka
> Priority: Major
> Fix For: Review Patch
>
> Attachments: codedCharacterSet.patch
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> The IPTC CodedCharacterSet tag can be used to specify the encoding of the
> IPTC tag values. But the setting is currently ignored.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
