ecki commented on issue #18: IMAGING-168 installing package with Swedish characters adds junk char… URL: https://github.com/apache/commons-imaging/pull/18#issuecomment-517662829 > I think @ecki was merely pointing out something to watch out while reviewing it, and as you explained, after this PR it should be configurable I think. Yes, exactly, the code I commented did not look like it is configurable. If it is, it might be fine (however configurable is not very useful in scenarios where you work on collections of files where some have different encoding, a binary transparent encoding instead of encoding exceptions is preferred in that case (at least to me).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
