robtimus commented on a change in pull request #89: Added TeeReader.
URL: https://github.com/apache/commons-io/pull/89#discussion_r311149043
##########
File path: src/test/java/org/apache/commons/io/input/TeeInputStreamTest.java
##########
@@ -30,6 +32,52 @@
*/
public class TeeInputStreamTest {
+ private static class ExceptionOnCloseByteArrayInputStream extends
ByteArrayInputStream {
Review comment:
These classes are based on similar classes in `TeeOutputStreamTest`. While I
could change the code to use `YellOnFlushAndCloseOutputStream`, I don't think
that `ClosedOutputStream` or `CloseShieldOutputStream` is feasible, as these
don't give access to its state; the test becomes more difficult to read because
the check on whether or not `close()` has been called would require a
try-fail-catch statement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
