bodewig commented on issue #79: Pull/78 COMPRESS-485 + Substituting 'synchronized' with faster and fully thread-safe collections 'ConcurrentLinkedDeque' and iterators. URL: https://github.com/apache/commons-compress/pull/79#issuecomment-519116588 Before #78 the `synchronized` would ensure you couldn't spin off new threads and add entries to them while writing or closing. With your change it would be possible to add new threads after writing has started and the result is not really defined (the iterator may see the new stream or it may not), right? Actually I looked through the history and initially we didn't synchronize the iterator when writing, this has been added as "recommended practice" via https://issues.apache.org/jira/browse/COMPRESS-430 - so we never really cared whether adding new threads while writing would lead to a defined result.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
