[
https://issues.apache.org/jira/browse/COMPRESS-485?focusedWorklogId=290485&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290485
]
ASF GitHub Bot logged work on COMPRESS-485:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Aug/19 14:15
Start Date: 07/Aug/19 14:15
Worklog Time Spent: 10m
Work Description: bodewig commented on issue #79: Pull/78 COMPRESS-485 +
Substituting 'synchronized' with faster and fully thread-safe collections
'ConcurrentLinkedDeque' and iterators.
URL: https://github.com/apache/commons-compress/pull/79#issuecomment-519116588
Before #78 the `synchronized` would ensure you couldn't spin off new threads
and add entries to them while writing or closing. With your change it would be
possible to add new threads after writing has started and the result is not
really defined (the iterator may see the new stream or it may not), right?
Actually I looked through the history and initially we didn't synchronize
the iterator when writing, this has been added as "recommended practice" via
https://issues.apache.org/jira/browse/COMPRESS-430 - so we never really cared
whether adding new threads while writing would lead to a defined result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 290485)
Time Spent: 2h 50m (was: 2h 40m)
> Reproducible Builds: keep entries order when gathering ScatterZipOutputStream
> content in ParallelScatterZipCreator
> ------------------------------------------------------------------------------------------------------------------
>
> Key: COMPRESS-485
> URL: https://issues.apache.org/jira/browse/COMPRESS-485
> Project: Commons Compress
> Issue Type: Improvement
> Components: Archivers
> Affects Versions: 1.18
> Reporter: Hervé Boutemy
> Priority: Major
> Fix For: 1.19
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> currently, zip files created using ParallelScatterZipCreator have random
> order.
> This is causing issues when trying to do Reproducible Builds with Maven
> MNG-6276
> Studying ParallelScatterZipCreator, entries are kept sorted in memory in
> futures list: instead of writing each full scatter in sequence, iterating
> over futures should permit to write each zip entry in original order, without
> changing the API or any performance of the gathering process
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
